-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove author landing page and metadata (authors b-c) #8222
base: nl-remove-author-data
Are you sure you want to change the base?
Conversation
@@ -4,14 +4,12 @@ first_name: Aaron | |||
last_name: Meyers | |||
# List your pronoun(s) if you want them displayed alongside your name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# List your pronoun(s) if you want them displayed alongside your name. |
@@ -4,14 +4,12 @@ first_name: Aaron | |||
last_name: Meyers | |||
# List your pronoun(s) if you want them displayed alongside your name. | |||
# If blank, we'll use just your name. Learn more http://mypronouns.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# If blank, we'll use just your name. Learn more http://mypronouns.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some of the author pages, this information is still included. In others, it's not. So I'm highlighting one example here, but I've seen some others as well.
I think we should remove all prompts (not just the pronouns ones) consistently, especially since this reads as "instructions for the author," and we don't really need to maintain those instructions in the metadata.
@@ -4,14 +4,12 @@ first_name: Aaron | |||
last_name: Meyers | |||
# List your pronoun(s) if you want them displayed alongside your name. | |||
# If blank, we'll use just your name. Learn more http://mypronouns.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some of the author pages, this information is still included. In others, it's not. So I'm highlighting one example here, but I've seen some others as well.
I think we should remove all prompts (not just the pronouns ones) consistently, especially since this reads as "instructions for the author," and we don't really need to maintain those instructions in the metadata.
|
||
|
||
|
||
|
||
|
||
# For more information on managing your author page, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# For more information on managing your author page, |
|
||
|
||
|
||
|
||
|
||
# For more information on managing your author page, | ||
# see https://workflow.digital.gov/authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# see https://workflow.digital.gov/authors |
This should be removed on all page metadata since the URL won't exist anymore.
Aid (FSA), an office at the U.S. Department of Education which is the largest | ||
provider of student financial aid in the nation. As the first Product Design | ||
Group at FSA, he is responsible for establishing human-centered design | ||
practices within the agency and leading/building a team of UX professionals | ||
overseeing the user experience for students, parents, and borrowers on | ||
StudentAid.gov and the myStudentAid app. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aid (FSA), an office at the U.S. Department of Education which is the largest | |
provider of student financial aid in the nation. As the first Product Design | |
Group at FSA, he is responsible for establishing human-centered design | |
practices within the agency and leading/building a team of UX professionals | |
overseeing the user experience for students, parents, and borrowers on | |
StudentAid.gov and the myStudentAid app. " |
The field is gone, but the metadata itself should still be removed.
Aid (FSA), an office at the U.S. Department of Education which is the largest | ||
provider of student financial aid in the nation. As the first Product Design | ||
Group at FSA, he is responsible for establishing human-centered design | ||
practices within the agency and leading/building a team of UX professionals | ||
overseeing the user experience for students, parents, and borrowers on | ||
StudentAid.gov and the myStudentAid app. " | ||
# e.g. U.S. General Services Administration | ||
agency_full_name: U.S. Department of Education | ||
# Agency Acronym [e.g., GSA] | ||
agency: ED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agency: ED | |
agency: U.S. Department of Education |
Aid (FSA), an office at the U.S. Department of Education which is the largest | ||
provider of student financial aid in the nation. As the first Product Design | ||
Group at FSA, he is responsible for establishing human-centered design | ||
practices within the agency and leading/building a team of UX professionals | ||
overseeing the user experience for students, parents, and borrowers on | ||
StudentAid.gov and the myStudentAid app. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some bits and pieces of metadata or helper text that I've flagged for removal. Although I have only flagged them in 1-2 places, they actually appear throughout the 2 sub-PRs. Some metadata still contains PII.
I also have a question about the consistency of the agency field, whether it is acronym only or spelled out (I suggest the latter, but I want to make sure that it is a proactive decision)
# Tell us where you live and work [e.g. 'New York City' or 'Portland, OR'] | ||
location: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Tell us where you live and work [e.g. 'New York City' or 'Portland, OR'] | |
location: "" |
All of this metadata should be removed if we're not going to ever include location again
@@ -7,22 +7,13 @@ first_name: "Alan" | |||
last_name: "Atlas" | |||
|
|||
# List your pronoun(s) if you want them displayed alongside your name. If blank, we'll use just your name. Learn more http://mypronouns.org | |||
pronoun: "" | |||
|
|||
# user id — not easily changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# user id — not easily changed |
University, combining both highly strategic and creative solutions to deliver | ||
client results based on business analytics and user experience practices. For | ||
the past 5 years, Alex has been supporting both federal and commercial clients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
University, combining both highly strategic and creative solutions to deliver | |
client results based on business analytics and user experience practices. For | |
the past 5 years, Alex has been supporting both federal and commercial clients |
Another example of a bio snippet to remove
Security (DHS), and now the United States Postal Service (USPS). Since 2019, | ||
he has been the User Experience Business Team Lead for USPS.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security (DHS), and now the United States Postal Service (USPS). Since 2019, | |
he has been the User Experience Business Team Lead for USPS.com. |
Summary
Metadata removal for author ranges B-C.
Note
Will be merged into #8216
Preview
Preview link