Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove author landing page and metadata (authors b-c) #8222

Open
wants to merge 2 commits into
base: nl-remove-author-data
Choose a base branch
from

Conversation

nick-mon1
Copy link
Contributor

@nick-mon1 nick-mon1 commented Nov 27, 2024

Summary

Metadata removal for author ranges B-C.

Note

Will be merged into #8216

Preview

Preview link

Copy link

🔍 Preview in Federalist

@nick-mon1 nick-mon1 changed the base branch from main to nl-remove-author-data November 27, 2024 16:31
@nick-mon1 nick-mon1 self-assigned this Nov 27, 2024
@nick-mon1 nick-mon1 marked this pull request as ready for review December 9, 2024 14:39
@@ -4,14 +4,12 @@ first_name: Aaron
last_name: Meyers
# List your pronoun(s) if you want them displayed alongside your name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# List your pronoun(s) if you want them displayed alongside your name.

@@ -4,14 +4,12 @@ first_name: Aaron
last_name: Meyers
# List your pronoun(s) if you want them displayed alongside your name.
# If blank, we'll use just your name. Learn more http://mypronouns.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# If blank, we'll use just your name. Learn more http://mypronouns.org

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some of the author pages, this information is still included. In others, it's not. So I'm highlighting one example here, but I've seen some others as well.

I think we should remove all prompts (not just the pronouns ones) consistently, especially since this reads as "instructions for the author," and we don't really need to maintain those instructions in the metadata.

@@ -4,14 +4,12 @@ first_name: Aaron
last_name: Meyers
# List your pronoun(s) if you want them displayed alongside your name.
# If blank, we'll use just your name. Learn more http://mypronouns.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some of the author pages, this information is still included. In others, it's not. So I'm highlighting one example here, but I've seen some others as well.

I think we should remove all prompts (not just the pronouns ones) consistently, especially since this reads as "instructions for the author," and we don't really need to maintain those instructions in the metadata.






# For more information on managing your author page,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# For more information on managing your author page,






# For more information on managing your author page,
# see https://workflow.digital.gov/authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# see https://workflow.digital.gov/authors

This should be removed on all page metadata since the URL won't exist anymore.

Comment on lines 6 to 11
Aid (FSA), an office at the U.S. Department of Education which is the largest
provider of student financial aid in the nation. As the first Product Design
Group at FSA, he is responsible for establishing human-centered design
practices within the agency and leading/building a team of UX professionals
overseeing the user experience for students, parents, and borrowers on
StudentAid.gov and the myStudentAid app. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Aid (FSA), an office at the U.S. Department of Education which is the largest
provider of student financial aid in the nation. As the first Product Design
Group at FSA, he is responsible for establishing human-centered design
practices within the agency and leading/building a team of UX professionals
overseeing the user experience for students, parents, and borrowers on
StudentAid.gov and the myStudentAid app. "

The field is gone, but the metadata itself should still be removed.

Aid (FSA), an office at the U.S. Department of Education which is the largest
provider of student financial aid in the nation. As the first Product Design
Group at FSA, he is responsible for establishing human-centered design
practices within the agency and leading/building a team of UX professionals
overseeing the user experience for students, parents, and borrowers on
StudentAid.gov and the myStudentAid app. "
# e.g. U.S. General Services Administration
agency_full_name: U.S. Department of Education
# Agency Acronym [e.g., GSA]
agency: ED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
agency: ED
agency: U.S. Department of Education

Comment on lines 6 to 11
Aid (FSA), an office at the U.S. Department of Education which is the largest
provider of student financial aid in the nation. As the first Product Design
Group at FSA, he is responsible for establishing human-centered design
practices within the agency and leading/building a team of UX professionals
overseeing the user experience for students, parents, and borrowers on
StudentAid.gov and the myStudentAid app. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some bits and pieces of metadata or helper text that I've flagged for removal. Although I have only flagged them in 1-2 places, they actually appear throughout the 2 sub-PRs. Some metadata still contains PII.

I also have a question about the consistency of the agency field, whether it is acronym only or spelled out (I suggest the latter, but I want to make sure that it is a proactive decision)

Comment on lines 12 to 13
# Tell us where you live and work [e.g. 'New York City' or 'Portland, OR']
location: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Tell us where you live and work [e.g. 'New York City' or 'Portland, OR']
location: ""

All of this metadata should be removed if we're not going to ever include location again

@@ -7,22 +7,13 @@ first_name: "Alan"
last_name: "Atlas"

# List your pronoun(s) if you want them displayed alongside your name. If blank, we'll use just your name. Learn more http://mypronouns.org
pronoun: ""

# user id — not easily changed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# user id — not easily changed

Comment on lines 6 to 8
University, combining both highly strategic and creative solutions to deliver
client results based on business analytics and user experience practices. For
the past 5 years, Alex has been supporting both federal and commercial clients
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
University, combining both highly strategic and creative solutions to deliver
client results based on business analytics and user experience practices. For
the past 5 years, Alex has been supporting both federal and commercial clients

Another example of a bio snippet to remove

Comment on lines 13 to 14
Security (DHS), and now the United States Postal Service (USPS). Since 2019,
he has been the User Experience Business Team Lead for USPS.com.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Security (DHS), and now the United States Postal Service (USPS). Since 2019,
he has been the User Experience Business Team Lead for USPS.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants