Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #7796

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Update PR template #7796

merged 3 commits into from
Jul 23, 2024

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jul 19, 2024

Summary

Updated PR template. Further updates to come as we agree on more fields.

Solution

Reformatting and removed unnecessary sections. Ideas taken from USWDS template.

Before After
image image

@mejiaj mejiaj requested review from nick-mon1 and RileySeaburg July 19, 2024 14:24
Copy link

🔍 Preview in Federalist

Comment on lines +38 to +45
## Dependency updates

### Dev Checklist
| Dependency name | Previous version | New version |
| ---------------------------- | :--------------: | :---------: |
| [Updated dependency example] | [1.0.0] | [1.0.1] |
| [New dependency example] | -- | [3.0.1] |
| [Removed dependency example] | [2.10.2] | -- |
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this addition, good call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, got it from the guidance @amyleadem created in USWDS.

@RileySeaburg RileySeaburg merged commit c7d51de into main Jul 23, 2024
8 checks passed
@RileySeaburg RileySeaburg deleted the jm-update-pr-template branch July 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants