Refactor markup for page templates #7795
Conversation
- Refactored resources/single.html - Refactored services/single.html
- Refactored resources/single.html - Refactored services/single.html squash w before
- Refactored resources/single.html - Refactored services/single.html
- Cleaned up code in markdown for /news single.html
There was a problem hiding this comment.
Suggestion
Like the updates to these pages @ch-tyson. I'm thinking with some of the clean up, we can possibly merge with @lcummings12 #7803
Fix
I fixed the prettier formatting with 9b08f82
| <p>Open to the public.</p> | ||
| <section> | ||
| {{- if .Params.summary -}} | ||
| <div class="content usa-prose"> |
There was a problem hiding this comment.
Issue
For some reason on my local, I see usa-prose increasing the font-size and font-weight. Can you confirm if this is happening for you and address?
There was a problem hiding this comment.
Is this used somewhere or just a draft file for what the markup structure should be?
There was a problem hiding this comment.
It's not used anywhere else and it was just for my convenience, should I remove?
There was a problem hiding this comment.
Todo
We can make a note to remove before merging if you need it for reference
nick-mon1
changed the title
- replace <aside> element with <div> for sidebar and simplify - wrap main content w/ section for consistency
- simplify header structure, remove unnecessary grid containers - remove redundant wrapper divs to streamline HTML structure - minor changes to news/single and docs/single
-remove nested grid containers and rows from header -remove unnecessary div wrappers -consistency across all single.html
| {{/* Google Stage */}} | ||
| {{- if eq .Params.event_platform "google" -}} | ||
| {{/* If is a Future Event */}} | ||
| {{- if eq $future_event true -}} | ||
| {{- .Render "stage-google" -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
|
|
There was a problem hiding this comment.
@ToniBonittoGSA It looks like we don't use google for future events anymore and we only have 20 files that use this option.
This code will only affect future events, we can remove it if we don't use google for event hosting.
There was a problem hiding this comment.
Lets comment this out for now no?
There was a problem hiding this comment.
Yes, thanks
cc: @jdotyoon
|
@nick-mon1 @lcummings12 now that the other 2 prs are merged, we have some conflicts to solve here. |
|
@RileySeaburg Addressed merge conflicts |
|
RileySeaburg
force-pushed
the
tc-refactor-main
branch
from
4aa9512 to
4e6a478
Compare
Summary
Refactors markup for single.html template to be more consistent.
Removes unused classes and duplicate markup.
Note
This PR should wait before merging #7803 & #7805
single.html
Preview
Link to Preview
Solution
Refactored markup to match a consistent hierarchy for all
single.htmlpages.main article header div.in-page-nav-container aside.usa-in-page-nav div.content.usa-proseDev Checklist