BUG: Fixing width on Topic Collection Pages #7442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clmedders
commented
Mar 26, 2024
| @@ -51,13 +51,6 @@ <h2 class="card-event__title" id="{{ .Title | urlize }}"> | |||
| </div> | |||
| {{- end -}} | |||
|
|
|||
| {{- if .Params.host -}} | |||
There was a problem hiding this comment.
after reviewing the file this code was getting a display none and looked to not being used at all.
clmedders
commented
Mar 26, 2024
| @@ -242,10 +243,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| .card-event__host { | |||
There was a problem hiding this comment.
removing due too display none and took out code above
clmedders
added
the
Dev: frontend
mejiaj
suggested changes
Mar 28, 2024
mejiaj
approved these changes
Mar 29, 2024
nick-mon1
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a width of 100% to fix issue with cards not going full width.
Preview
Link to Preview
Solution
Adding
width: 100%;to address the error that was according when text was below a certain amount. This was causing the width to be dependent on the about the text that was present on the card.How To Test
DG BUG: width & alignment in topic collection pagesfor more context)Dev Checklist