Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Topics Component Refactor #7376

Merged
merged 45 commits into from
Apr 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
b6689f0
Creating partial for topics button
clmedders Mar 4, 2024
e267710
linting updates
clmedders Mar 4, 2024
915fb20
adding partial from new topics button
clmedders Mar 4, 2024
dd00d45
Updating style sheet
clmedders Mar 4, 2024
2b13a63
Linting and file clean up
clmedders Mar 4, 2024
760a17f
Merge remote-tracking branch 'origin' into cm-topics-button-component
clmedders Mar 4, 2024
f2385fc
linting fix
clmedders Mar 4, 2024
1b2d697
file clean up
clmedders Mar 4, 2024
7e4e7ab
linting fix
clmedders Mar 4, 2024
3c699f3
Merge branch 'main' into cm-topics-button-component
nick-mon1 Mar 5, 2024
22ef639
Updated markup, styles to be consistent
nick-mon1 Mar 6, 2024
3be29b2
Fixed prettier error
nick-mon1 Mar 6, 2024
fa8f228
Removed un-necessary markup
nick-mon1 Mar 6, 2024
7e6ec1f
Removed comments
nick-mon1 Mar 6, 2024
67be07f
Fixed template logic comments by @mejiaj
nick-mon1 Mar 11, 2024
e98fff2
updates to files after code review
clmedders Mar 15, 2024
9da3ea9
linting updates
clmedders Mar 15, 2024
fbbedc2
linting updates
clmedders Mar 15, 2024
a683f17
adding transition effect on arrow
clmedders Mar 15, 2024
6ba3dfd
adding single prop css styles
clmedders Mar 15, 2024
ce2835f
linting updates
clmedders Mar 15, 2024
e80048e
updating from change request to partial
clmedders Mar 18, 2024
15d85e1
updating from change request to style sheet
clmedders Mar 18, 2024
7ddc3d3
linting updates
clmedders Mar 18, 2024
b360e49
updating visited action for primary to stay with base color
clmedders Mar 18, 2024
ba6491b
linting updates
clmedders Mar 18, 2024
7b9326e
Merge branch 'main' into cm-topics-button-component
mejiaj Mar 19, 2024
991ff7d
updating padding for link to fix wrapping issue
clmedders Mar 19, 2024
0090b39
checking verified access
clmedders Mar 19, 2024
057a456
linting update
clmedders Mar 19, 2024
c9db283
checking signoff
clmedders Mar 19, 2024
0051467
linting fix
clmedders Mar 19, 2024
1492111
Refactored mixins to functions, fixed 2 minor visual bugs
nick-mon1 Mar 20, 2024
b837ef9
Updating bug that came up with padding
clmedders Mar 22, 2024
77109db
linting updates
clmedders Mar 22, 2024
4b46657
Merge remote-tracking branch 'origin' into cm-topics-button-component
clmedders Mar 22, 2024
11cad11
removed zombie code
clmedders Mar 22, 2024
5d69ba1
Merge branch 'main' into cm-topics-button-component
nick-mon1 Mar 22, 2024
9567382
fixed spacing on mobile for count link
clmedders Mar 22, 2024
df16dcf
linting updates
clmedders Mar 22, 2024
c35c4a2
linting updates
clmedders Mar 22, 2024
f1718ab
Replaced px-to-rem with units
nick-mon1 Mar 22, 2024
9f0d0db
Remove unnecessary grid row
mejiaj Mar 28, 2024
9dae523
Merge branch 'main' into cm-topics-button-component
mejiaj Apr 1, 2024
15dd166
Merge remote-tracking branch 'origin' into cm-topics-button-component
clmedders Apr 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion themes/digital.gov/src/scss/new/_topics-button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
white-space: nowrap;

@include at-media("tablet") {
padding-left: units(1);
padding-left: 6px;
padding-right: 6px;
clmedders marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down