Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POAM: April 2024 #371

Merged
merged 1 commit into from
Apr 12, 2024
Merged

POAM: April 2024 #371

merged 1 commit into from
Apr 12, 2024

Conversation

clmedders
Copy link
Contributor

This PR handles security vulnerabilities for April 2024

There are multiple files that needed to be rebuilt based on the new USWDS version and an update to the Pa11y testing script to excluded any pdf urls

Testing:

  • Pull down branch and run npm install and ensure no build errors
  • Start local with npm run start and visit local and visually inspect site to ensure no regressions
  • Local run npm run test:pa11y to ensure no accessibility errors
DependenciesDependency Old New
 USWDS 3.71 3.8.0 
Sass 1.69.7 1.74.1

@clmedders clmedders mentioned this pull request Apr 8, 2024
Closed
@clmedders clmedders marked this pull request as draft April 8, 2024 20:59
@clmedders clmedders requested review from nick-mon1 and mejiaj April 9, 2024 01:14
@clmedders clmedders self-assigned this Apr 9, 2024
@clmedders clmedders added the dependencies Pull requests that update a dependency file label Apr 9, 2024
@clmedders clmedders marked this pull request as ready for review April 9, 2024 01:15
mejiaj
mejiaj approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not seeing any visual regressions.

nick-mon1
nick-mon1 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@nick-mon1 nick-mon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I Tested:

  1. npm run start runs and no visual changes or functional changes ( see drop down list)
  2. npm run test:pa11y passes

@ToniBonittoGSA ToniBonittoGSA merged commit 662bccd into main Apr 12, 2024
6 checks passed
@ToniBonittoGSA ToniBonittoGSA deleted the cm-poam-apr-24 branch April 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-mon1 nick-mon1 nick-mon1 approved these changes

@mejiaj mejiaj mejiaj approved these changes

@ToniBonittoGSA ToniBonittoGSA Awaiting requested review from ToniBonittoGSA

Assignees

@clmedders clmedders

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clmedders @mejiaj @nick-mon1 @ToniBonittoGSA