Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text to social media links in footer #361

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jaredbain
Copy link
Contributor

@jaredbain jaredbain commented Oct 18, 2023

Adds accessibility text to social media links in footer

Fixes #327

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have performed a self-review of my own code and have no open issues
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings or syntax errors
  • I have verified Draft on actual mobile devices, especially Safari-based

@jaredbain jaredbain marked this pull request as ready for review October 18, 2023 19:54
Copy link
Contributor

@chriskuang4 chriskuang4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jaredbain jaredbain merged commit e3f0990 into main Oct 19, 2023
4 checks passed
@jaredbain jaredbain deleted the accessibility_text_social_links branch October 19, 2023 14:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Screen readers do not have text to read links - link contains no text.
3 participants