Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project url slugs #333

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Update project url slugs #333

merged 7 commits into from
Oct 5, 2023

Conversation

jaredbain
Copy link
Contributor

update project url slugs

Fixes #332

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have performed a self-review of my own code and have no open issues
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings or syntax errors
  • I have verified Draft on actual mobile devices, especially Safari-based

@jaredbain jaredbain marked this pull request as ready for review September 27, 2023 14:52
@chriskuang4
Copy link
Contributor

@jaredbain would this break any existing links? Is there a way that we could handle this?

Copy link
Contributor

@chriskuang4 chriskuang4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; @jaredbain will do one last look before merging:

  • Verify all instances of the URL updating have been caught
  • Work on redirecting from /acf-iprc to the new slug (for social media/posts already in the wild)

@jaredbain jaredbain merged commit 6d0b555 into main Oct 5, 2023
4 checks passed
@jaredbain jaredbain deleted the update_project_url_slugs branch October 5, 2023 20:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change URL slug for impact story/stories
3 participants