update mdtranslator branch; add valid and invalid controller tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btylerburton
previously approved these changes
Nov 13, 2024
|
Is this failing |
|
i'm looking into it |
|
reproducing the error locally produces an error involving the ruby version of the app. looks like the cloud foundry ruby buildpack dropped support for ruby 3.2.2 from 1.10.7 to 1.10.18. gonna bump the ruby version to 3.3.4 and see if it resolves the issue. |
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
d987d11 to
5b20973
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
bbffaab to
f789f0f
Compare
rshewitt
force-pushed
the
update-mdt-branch
branch
from
f789f0f to
ed38fe2
Compare
|
i think the app got in a weird state so i deleted it and re-ran the deploy and it worked. gonna keep an eye on this. |
rshewitt
force-pushed
the
update-mdt-branch
branch
from
ed38fe2 to
1bd5d3a
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
1bd5d3a to
0f583b9
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
0f583b9 to
282bac6
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
282bac6 to
09d4bdf
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
da684b7 to
1d3032a
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
rshewitt
force-pushed
the
update-mdt-branch
branch
from
2b9e782 to
dffa052
Compare
rshewitt
had a problem deploying
to
development
GitHub Actions
Failure
|
it seems that updating the number of instances in the vars file allowed the app to deploy. however, this hasn't been an issue in the past so i'm curious. |
btylerburton
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4565