Merge pull request #1 from GSA/update-status-code

Update transformation response code

.rubocop.yml

@@ -13,4 +13,7 @@ Metrics/MethodLength:
   Enabled: false
 
 Metrics/PerceivedComplexity:
-  Enabled: false
+  Enabled: false
+
+AllCops:
+    NewCops: disable

Makefile

@@ -1,2 +1,12 @@
 build: ## Build the app image
-	docker build -t datagov/mdtranslator . 
+	docker build -t datagov/mdtranslator . 
+
+start:
+	rails server -b 0.0.0.0 -p 3000
+
+lint:
+	bundle exec rubocop
+
+.PHONY: test
+test:
+	rails test

app/controllers/translates_controller.rb

@@ -70,6 +70,6 @@ def create
     @response_info[:success] = false unless @md_return[:readerExecutionPass]
     @response_info[:success] = false unless @md_return[:writerPass]
 
-    render json: @response_info
+    render json: @response_info, status: @response_info[:success] ? 200 : 422
   end
 end

test/controllers/translates_controller_test.rb

@@ -3,11 +3,17 @@
 require 'test_helper'
 
 class TranslatesControllerTest < ActionDispatch::IntegrationTest
-  test 'post transformation of fgdc to iso19115_3' do
-    @translate = translates(:fgdc_to_iso)
-    @file = File.read(File.expand_path("../../fixtures/#{@translate.file}", __FILE__))
-    post '/translates', params: { translate: { file: @file,
-                                               reader: @translate.reader, writer: @translate.writer } }, as: :json
+  test 'post valid transformation of sbJson to mdJson' do
+    @translate = translates(:sbjson_to_mdjson)
+    @file = File.read(File.join(File.dirname(__FILE__), "../fixtures/#{@translate.file}"))
+    post '/translates', params: { file: @file, reader: @translate.reader, writer: @translate.writer }, as: :json
     assert_response 200
   end
+
+  test 'post invalid transformation of fgdc to iso19115_3' do
+    @translate = translates(:fgdc_to_iso)
+    @file = File.read(File.join(File.dirname(__FILE__), "../fixtures/#{@translate.file}"))
+    post '/translates', params: { file: @file, reader: @translate.reader, writer: @translate.writer }, as: :json
+    assert_response 422
+  end
 end