Production Release (#259)

Sprint 33 include(s) the following issues: Improve performance by adding explicit height and width to image elements #146 Interactive elements indicate their purpose and state #185
GSA · Jul 1, 2024 · ef66741 · ef66741
1 parent bffbf25
commit ef66741
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
@@ -22,7 +22,6 @@ jobs:
           cf_space: ${{ inputs.environment }}
           command: >-
             bin/cg-set-env.sh ${{ inputs.environment }}
-            SAM_API_KEY=${{ secrets.SAM_API_KEY }}
 
       - name: Deploy the application
         uses: cloud-gov/cg-cli-tools@main

diff --git a/front-end/src/components/Banner.vue b/front-end/src/components/Banner.vue
@@ -8,6 +8,8 @@
         <div class="usa-banner__inner">
           <div class="grid-col-auto">
             <img
+              width="16"
+              height="11"
               aria-hidden="true"
               class="usa-banner__header-flag"
               src="@/assets/images/us_flag_small.png"

diff --git a/front-end/src/components/GSAHeader.vue b/front-end/src/components/GSAHeader.vue
@@ -21,6 +21,8 @@ defineProps({
       >
         <router-link to="/">
           <img
+            width="189.5"
+            height="72"
             class="usa-logo-img"
             src="@/assets/images/gsa-smartpay-logo-reverse.svg"
             alt="GSA SmartPay Logo"
@@ -37,6 +39,8 @@ defineProps({
         class="usa-logo"
       >
         <img
+          width="189.5"
+          height="72"
           class="usa-logo-img"
           src="@/assets/images/gsa-smartpay-logo-reverse.svg"
           alt="GSA SmartPay Logo"

diff --git a/front-end/src/components/SearchResult.vue b/front-end/src/components/SearchResult.vue
@@ -105,6 +105,12 @@ const expirationDateText = computed(() => {
 const downloadLabel = computed(
   () => "Download PDF for " + props.entity.entityRegistration.legalBusinessName,
 );
+
+const downloadLabelId = computed(
+  () => downloadLabel.value.toLowerCase().replace(/\s+/g, '-'),
+);
+
+
 </script>
 <template>
   <div
@@ -124,9 +130,9 @@ const downloadLabel = computed(
           focusable="false"
           role="img"
           class="usa-icon"
-          :aria-labelledby="downloadLabel"
+          :aria-label="downloadLabel"
         >
-          <title :id="downloadLabel">{{ downloadLabel }}</title>
+          <title :id="downloadLabelId">{{ downloadLabel }}</title>
           <use xlink:href="@/assets/images/sprite.svg#file_download" />
         </svg>
       </button>
@@ -144,7 +150,7 @@ const downloadLabel = computed(
           focusable="true"
           role="img"
           class="usa-icon"
-          aria-labelledby="no-download"
+          :aria-label="WARN_TEXT"
         >
           <title id="no-download">{{ WARN_TEXT }}</title>
           <use xlink:href="@/assets/images/sprite.svg#remove_circle" />
@@ -170,7 +176,7 @@ const downloadLabel = computed(
           <svg
             class="usa-icon"
             focusable="true"
-            aria-labelledby="green-check"
+            :aria-label="OK_TEXT"
             role="img"
           >
             <title id="green-check">{{ OK_TEXT }}</title>
@@ -187,7 +193,7 @@ const downloadLabel = computed(
           <svg
             class="usa-icon"
             aria-hidden="true"
-            aria-labelledby="warning-icon"
+            :aria-label="WARN_TEXT"
             focusable="false"
             role="img"
           >