Add command to recursively clean node_modules directory #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform plan for tts-10x-atj-dev Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:d692905ca9d9e0a5b19050682e83ae0beef67152" -> "ghcr.io/gsa-tts/forms/server-doj:583b908531ca8699990207283b0f47539b46ad63"
id = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
name = "tts-10x-atj-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-kansas:d692905ca9d9e0a5b19050682e83ae0beef67152" -> "ghcr.io/gsa-tts/forms/server-kansas:583b908531ca8699990207283b0f47539b46ad63"
id = "e885e531-11b7-4906-9cc3-0ddf483868f5"
name = "tts-10x-atj-dev-server-kansas-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #482 |
kalasgarov
approved these changes
Dec 18, 2024
| @@ -9,6 +9,7 @@ | |||
| "scripts": { | |||
| "build": "turbo run build --filter=!@atj/infra-cdktf", | |||
| "clean": "turbo run clean", | |||
| "clean:modules": "find $(git rev-parse --show-toplevel) -name 'node_modules' -type d -prune -exec rm -rf '{}' +", | |||
There was a problem hiding this comment.
Thank you for adding this to scripts! Should we also include .dist folders too?
There was a problem hiding this comment.
Thanks @kalasgarov. I haven't personally encountered scenarios where I've had to recursively delete the dist directories to resolve issues. Is that something you've had to do? I can add before merging if so.
There was a problem hiding this comment.
I usually delete them to solve the caching issues that never ends :) , but I might be overthink about it. You are good to merge the PR without it 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses git plumbing to add a command at the workspace root to clean modules since there have been times when we needed to do so.