Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update head tag order #407

Merged
merged 4 commits into from
Dec 23, 2024
Merged

update head tag order #407

merged 4 commits into from
Dec 23, 2024

Conversation

ethangardner
Copy link
Contributor

@ethangardner ethangardner commented Dec 13, 2024

There is an ideal <head> tag order for frontend assets. This moves us closer to that and removes some unused assets.

@ethangardner ethangardner marked this pull request as draft December 13, 2024 21:44
Copy link

github-actions bot commented Dec 13, 2024

Terraform plan for tts-10x-atj-dev

Plan: 0 to add, 2 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-doj:1c9df5e5a97bc4e81aeb7124dec7c36aeda4dfee" -> "ghcr.io/gsa-tts/forms/server-doj:eaf04eda115e200795c18a3aec2acd96a13a2d6e"
        id                              = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
        name                            = "tts-10x-atj-dev-server-doj-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

  # cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-kansas:1c9df5e5a97bc4e81aeb7124dec7c36aeda4dfee" -> "ghcr.io/gsa-tts/forms/server-kansas:eaf04eda115e200795c18a3aec2acd96a13a2d6e"
        id                              = "e885e531-11b7-4906-9cc3-0ddf483868f5"
        name                            = "tts-10x-atj-dev-server-kansas-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

📝 Plan generated in Post Terraform plan to PR comment #515

@ethangardner ethangardner marked this pull request as ready for review December 18, 2024 16:37
Copy link
Contributor

@danielnaab danielnaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ethangardner ethangardner merged commit b355f84 into main Dec 23, 2024
4 checks passed
@ethangardner ethangardner deleted the task/head-tag branch December 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants