Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update folder structure for form manager tckt-394 #396

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

kalasgarov
Copy link
Contributor

No description provided.

@kalasgarov kalasgarov force-pushed the refactor/394-folder-structure branch from f7e64df to ff57f58 Compare December 3, 2024 22:56
@kalasgarov kalasgarov self-assigned this Dec 4, 2024
Copy link

github-actions bot commented Dec 5, 2024

Terraform plan for tts-10x-atj-dev

Plan: 0 to add, 2 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-doj:7af78d490aa61c867380bc8e98876bdf2452feb9" -> "ghcr.io/gsa-tts/forms/server-doj:3b2df13aaec12722230e2f04c0cf33e84255e835"
        id                              = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
        name                            = "tts-10x-atj-dev-server-doj-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

  # cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-kansas:7af78d490aa61c867380bc8e98876bdf2452feb9" -> "ghcr.io/gsa-tts/forms/server-kansas:3b2df13aaec12722230e2f04c0cf33e84255e835"
        id                              = "e885e531-11b7-4906-9cc3-0ddf483868f5"
        name                            = "tts-10x-atj-dev-server-kansas-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

📝 Plan generated in Post Terraform plan to PR comment #454

Copy link
Contributor

@ethangardner ethangardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a strong preference either way on this.

It made sense to me to have the flatter structure before and only putting the more complicated components with static assets in a directory, but this makes sense to me too.

Copy link
Contributor

@danielnaab danielnaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this opportunity for consistency.

@kalasgarov kalasgarov merged commit d1c388f into main Dec 6, 2024
4 checks passed
@kalasgarov kalasgarov deleted the refactor/394-folder-structure branch December 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants