update playwright (#340)

GSA-TTS · Oct 21, 2024 · afbde7f · afbde7f
1 parent b21c1e7
commit afbde7f
Show file tree

Hide file tree

Showing 6 changed files with 167 additions and 167 deletions.
diff --git a/.github/workflows/_validate.yml b/.github/workflows/_validate.yml
@@ -45,7 +45,7 @@ jobs:
         run: pnpm install
 
       - name: Install playwright
-        run: pnpm dlx playwright install --with-deps
+        run: pnpm dlx playwright@1.48.1 install --with-deps
 
       # While most of the test suite is self-contained, the tests for the demo
       # servers require a prod build of @atj/server.

diff --git a/README.md b/README.md
@@ -42,7 +42,7 @@ This project uses [pnpm workspaces](https://pnpm.io/workspaces). To work with th
 pnpm install
 ```
 
-To install the browsers needed for the Storybook testing with `@vitest/browser`, you need to do a one-time install with `pnpm dlx install playwright --with-deps`. To run the complete test suite, with coverage metrics generated:
+To install the browsers needed for the Storybook testing with `@vitest/browser`, you need to do a one-time install with `pnpm dlx playwright@1.48.1 install --with-deps`. This command also needs to be run when Playwright is updated because it requires version parity to find the executables across the local dev environment and CI to get all the tests to pass. To run the complete test suite, with coverage metrics generated:
 
 ```bash
 pnpm test

diff --git a/e2e/Dockerfile b/e2e/Dockerfile
@@ -1,5 +1,5 @@
 # base image with Node.js and playwright preinstalled
-FROM mcr.microsoft.com/playwright:v1.47.2-noble as base
+FROM mcr.microsoft.com/playwright:v1.48.1-noble as base
 ENV PNPM_HOME="/pnpm"
 ENV PATH="$PNPM_HOME:$PATH"
 ENV NODE_ENV=test

diff --git a/e2e/package.json b/e2e/package.json
@@ -7,7 +7,7 @@
     "test": "export E2E_ENDPOINT=http://localhost:4321; pnpm playwright test --ui-port=8080 --ui-host=0.0.0.0"
   },
   "devDependencies": {
-    "@playwright/test": "^1.47.2",
+    "@playwright/test": "1.48.1",
     "@storybook/test-runner": "^0.19.1",
     "path-to-regexp": "^7.1.0"
   },

diff --git a/packages/design/package.json b/packages/design/package.json
@@ -25,7 +25,7 @@
     "dist/**/*"
   ],
   "devDependencies": {
-    "@playwright/test": "^1.47.2",
+    "@playwright/test": "1.48.1",
     "@storybook/addon-a11y": "^8.2.8",
     "@storybook/addon-coverage": "^1.0.4",
     "@storybook/addon-essentials": "^8.2.8",
@@ -56,7 +56,7 @@
     "install": "^0.13.0",
     "jsdom": "^24.1.1",
     "onchange": "^7.1.0",
-    "playwright": "^1.47.2",
+    "playwright": "1.48.1",
     "prop-types": "^15.8.1",
     "react-dom": "^18.3.1",
     "vite": "^5.4.0",