Replace LARK with a hand-written parser. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed bug where code actually was run with `check_shapes` which shouldn't have been. * Removed `check_shapes` imports in the `without` code. * Store the `with` and `without` temporary files at separate paths. * Refactored some statistics code into a separate module. * Print estimated overhead when running `run_benchmark`. * Added plot of absolute overhead.
jesnie
force-pushed
the
jesper/handwritten_parser
branch
from
56bdeed
to
0281cf0
Compare
* This is faster and reduces the overhead of `check_shapes` somewhat. * This removes an external dependency of `check_shapes`.
jesnie
force-pushed
the
jesper/handwritten_parser
branch
from
0281cf0
to
96614d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace LARK with a hand-written parser:
check_shapessomewhat.Examples of before and after overhead:
from
check_shapes.Honestly I'm not 100% sure this is an improvement. I was hoping for a larger improvement in speed.