Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev archive patch for recent PR merge. #1389

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

tsteven4
Copy link
Collaborator

#1387 invalidated previous patch.

@tsteven4 tsteven4 merged commit 36b5007 into GPSBabel:master Nov 25, 2024
18 checks passed
@tsteven4 tsteven4 deleted the devupdate branch November 25, 2024 13:57
@robertlipe
Copy link
Collaborator

robertlipe commented Nov 25, 2024 via email

@tsteven4
Copy link
Collaborator Author

  1. I think that would cause trouble. the dev docker image is a pre-release image with a version # like GPSBabel 1.9.0+b8068b91 . The intent of that string is to say this was build from 1.9.0 with additional changes from git commit b8068b9 (as is used in other projects). The "shorter string wins" rule in upgrade.cc is going to suggest an upgrade to 1.9.0.
  2. Not only is an upgrade to 1.9.0 a downgrade, the docker image is only upgradeable by me pushing a new image to dockerhub, after which the user can "docker pull".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants