forked from FriendsOfGalaxy/galaxy-integration-uplay
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Test use new build action #3
Open
UncleGoogle
wants to merge
10
commits into
master
Choose a base branch
from
feature/use_new_build_action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
84405e7
simplify existing build job
UncleGoogle e4f3a41
experiemnt with new action
UncleGoogle 2802088
rm param to ls
UncleGoogle 09e24c7
add mac
UncleGoogle 4afc7f7
debug run
UncleGoogle aff8d6f
update action to do not pass arch explicitly
UncleGoogle c34d6a6
Fix zipping wrong dir
UncleGoogle 9d80d02
User runner.os name in zip files instead of longer declarative os
UncleGoogle 6eef650
add explicit target to build action input params
UncleGoogle 743e9ff
add thoughts about release plugin action
UncleGoogle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@urwrstkn8mare planning futher steps here. Please take a look 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UncleGoogle I think we should use Option 3. So that all commits to other branches will have build artifacts so other people can download it and test it. But when changes are merged to master (with mandatory version bump) we can release the previously built artifact. Is that something that sounds good to you? Option 2b might also be able to be used instead for the same flow I think?