[2주차] 기본 과제 #3
Open
[2주차] 기본 과제 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
과제 하느라 고생 많으셨습니다~! 🙌 |
euije
reviewed
Apr 12, 2023
| Post post = postList.get((int) (postId - 1)); | ||
| return new ResponseDto(post); | ||
| } catch (Exception e) { | ||
| throw new IllegalArgumentException("해당 아이디의 게시글이 존재하지 않습니다."); |
There was a problem hiding this comment.
- Node 환경에서는 Runtime-Error 발생 시, process가 종료되어 Exception throwing을 지양하는데,
Spring은 이와 다르게 Servlet Layer에서 처리해주어서 process가 종료되지 않네요!
이를 가만하면, try-catch를 통한 에러 처리를 지향하는 Java 진영에서의 입장에서 좋은 코드인 것 같습니다!
| return new ResponseDto(post); | ||
| } | ||
| } | ||
| throw new IllegalArgumentException("해당 제목의 게시글이 존재하지 않습니다."); |
There was a problem hiding this comment.
- Exception 중, IllegalArgumentException를 선택하신 이유가 궁금합니다
Java에서 코딩할 때, Exception 클래스를 선택하는 기준이 있는지 궁금합니다!
바로 전자의 리뷰에서 ArrayList<T>.get() 메소드는 비정상적인 index 입력시,
IndexOutOfBoundsException를 throw 하는데, 동일한 exception을 발생시키는 건 어떻게 생각하시나요?
(제가 잘 몰라서 질문 던집니다.. ㅎ)
try {
...
} catch (Exception e) {
throw e;
}There was a problem hiding this comment.
단순히 이제까지 Dto 단에서 @Valid 어노테이션을 이용해서 오류를 핸들링할 때 항상 IllegalArgumentException 가 발생해서 단순히 이번에도 그렇게 처리했던건데 제가 미처 생각지 못한 부분이네요!! 일관성 있게 해당 에러를 던지는 것으로 수정해볼게요 감사합니당
seunghaLim
reviewed
Apr 17, 2023
| private final UserService userService; | ||
|
|
||
| @PostMapping("/user") | ||
| public String register(@RequestBody final RequestDto request) { |
There was a problem hiding this comment.
RequestDto를 받아올 때 final 키워드와 함께 받아오는 부분 좋아보이네요 참고하겠습니다~!!
onpyeong
reviewed
Apr 21, 2023
| import lombok.ToString; | ||
| import sopt.org.SecondSeminar.domain.post.Post; | ||
|
|
||
| @ToString |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 관련 이슈
closed #6
👩🏻💻 내용
😸 중점을 둔 부분
중간에 커밋이 꼬여서 다시 올렸어요 ㅠㅡㅠ