[week 2] 기본과제/생각과제/심화과제 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeorinY
reviewed
Apr 22, 2023
| System.out.println(boardList.get(boardId.intValue() - 1).toString()); | ||
|
|
||
| return boardId + "번 게시물이 등록되었습니다!"; | ||
| } |
There was a problem hiding this comment.
메서드 끝나도 들여쓰기 해주면 좋다고 들었어요!!
자바 코드 컨벤션 구글링하면 참고하실 수 있습니다!
There was a problem hiding this comment.
제가 자바가 익숙하지 않아서 잘 몰랐는데 말씀해주셔서 감사합니다!! :)
| @Getter | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| public class BoardRegisterRequestDto { | ||
| private String title; |
There was a problem hiding this comment.
Dto는 값이 바뀌지 않는 객체기 때문에 final 로 변수를 선언해주면 조금 더 데이터가 보호될 것 같아요!
| return "유저 조회 성공"; | ||
| } | ||
|
|
||
| @GetMapping("user/search") |
There was a problem hiding this comment.
"/user/search" 가 되면 더 좋은 Rest ful URI 로 만들 수 있을 것 같아요!
There was a problem hiding this comment.
Restful URI에 대해서 더 공부해보겠습니당!감사합니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본과제
2.3,4 게시물 생성,조회(게시물 내용 조회), 제목으로 게시물 검색
생각과제
https://canyon-rhythm-70f.notion.site/2-5ee558b81dc14674835370e98e1c3278