Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1339 #1404

Open
wants to merge 7 commits into
base: master-3.0
Choose a base branch
from
Open

Bugfix 1339 #1404

wants to merge 7 commits into from

Conversation

rajnikantsolarwinds
Copy link

No description provided.

@grossmj grossmj linked an issue Oct 19, 2022 that may be closed by this pull request
@grossmj
Copy link
Member

grossmj commented Oct 19, 2022

This PR is incomplete to solve #1339

For instance editing a Qemu template gives this error:

Screenshot from 2022-10-19 12-38-43

I cannot configure a MAC address for custom adapters:

Screenshot from 2022-10-19 12-38-08

For info here is what we have in the server to validate a custom adapter:

    adapter_number: int
    port_name: str
    adapter_type: Optional[str] = None
    mac_address: Optional[str] = Field(None, regex="^([0-9a-fA-F]{2}[:]){5}([0-9a-fA-F]{2})$")

adapter_number and port_name are mandatory. adapter_type and mac_address are optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webui missing custom network adapter option for node
2 participants