Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary: Refactored ..utils.asyncio.telnet_server.py to use telnetlib3… #2342

Closed
wants to merge 6 commits into from

Commits on Jan 27, 2024

  1. Summary: Refactored ..utils.asyncio.telnet_server.py to use telnetlib…

    …3 library, enhanced command handling and error management..
    
    Extended description:
    - Migrated to telnetlib3 for improved handling of Telnet commands and options.
    - Upgraded TelnetConnection with error handling in send and close methods.
    - Refined AsyncioTelnetServer by inheriting from telnetlib3.TelnetServer, featuring streamlined command processing and enhanced logging.
    - Removed unnecessary dependencies and imports, simplifying the codebase.
    - Retained the core execution flow, adapting it to the new class structures.
    
    Observation for Future Improvement:
    - Some NVT commands are still marked as unhandled in debug logs despite having the necessary handling statments. This behaviour may be related to certain user-reported bugs.
    - Further comprehensive testing and diagnostics are needed to understand and resolve these issues.
    
    Next Steps:
    - A detailed code review focusing on prerequisites and requirements is suggested. This will determine which functions can be effectively delegated to telnetlib3 without negatively impacting other GNS3 modules.
    - The goal is to ensure optimal integration of telnetlib3, maximizing efficiency while preserving the integrity and functionality of the broader GNS3 ecosystem.
    KCarmichael committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    9b6c1a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    f201616 View commit details
    Browse the repository at this point in the history
  2. Update requirements.txt

    KCarmichael authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    5ed409f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    c972726 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    aceef6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a91740d View commit details
    Browse the repository at this point in the history