C app interface #2691
C app interface #2691
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| @@ -239,6 +239,66 @@ const char* helicsEndpointGetDefaultDestination(HelicsEndpoint endpoint) | |||
| return str.c_str(); | |||
| } | |||
|
|
|||
| void helicsEndpointSendString(HelicsEndpoint endpoint, const char* message, HelicsError* err) | |||
There was a problem hiding this comment.
These functions are new and need to be included in the Python et al interfaces.
| * @return An opaque value app object nullptr if the object creation failed. | ||
| */ | ||
| HELICS_EXPORT HelicsApp | ||
| helicsCreateApp(const char* appName, const char* appType, const char* configFile, HelicsFederateInfo fedInfo, HelicsError* err); |
There was a problem hiding this comment.
Why are these in a folder called backup?
There was a problem hiding this comment.
If python is present and enabled they are automatically generated and the backups now used. But if not these files get used.
| * @param[in,out] err An error object that will contain an error code and string if any error occurred during the execution of the function. | ||
|
|
||
| * | ||
| * @return An opaque value app object nullptr if the object creation failed. |
There was a problem hiding this comment.
These are the files we need to actually need to make available to other languages. This is a reminder to myself.
|
|
||
| auto M = helicsEndpointGetMessage(epid2); | ||
| // ASSERT_TRUE (M); | ||
| ASSERT_EQ(helicsMessageGetByteCount(M), 500); |
There was a problem hiding this comment.
It would be nice to set a strange time for the message and then verify that exactly that time is propagated to the message object.
There was a problem hiding this comment.
I believe that is tested in the main suite of message federate tests, here we are mainly testing that the api call works as intended.
| int index{-2}; | ||
| int valid{0}; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Quick answer is no one needed it before now. There are some desired applications (by various programs) that require the connector to be able to execute in the same process as other applications, so it made the most sense to expose other apps in the same way as those will also likely be needed in the future.
|
I forgot to mention, but the build failure for helics looks real. |
Co-authored-by: Ryan Mast <[email protected]>
for more information, see https://pre-commit.ci
Summary
If merged this pull request will add an interface for the helicsApps in the C shared library
Proposed changes