Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker instructions to use Ubuntu 22.04 #2594

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

beroset
Copy link
Contributor

@beroset beroset commented Jan 17, 2024

Summary

If merged this pull request will update the docker instructions to build using a base image of Ubuntu 22.04 rather than 18.04 which no longer builds. This fixes #2593.

Proposed changes

Change the build instructions to use Ubuntu 22.04 as base. Within the documented Dockerfile the changes are:

  • Install libboost-all-dev rather than individual boost package for the builder (since we don't care about size for this)
  • clone with --recurse-submodules
  • use modern cmake --build syntax to eliminate steps
  • specify "Release" build to make smaller image
  • combine installation steps in target version
  • update install to include pip and up-to-date versions of boost components

This updates the docker instructions to build using a base image of
Ubuntu 22.04 rather than 18.04 which no longer builds.  This fixes

Signed-off-by: Ed Beroset <[email protected]>
Copy link
Member

@phlptp phlptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This area of the documentation probably needs some more updates as I think there might be a few more unnecessary things in here, but this is great, thanks!

@phlptp phlptp merged commit 2b0d041 into GMLC-TDC:main Jan 24, 2024
13 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build instructions in docker.md no longer work
3 participants