Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow artifacts #2588

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Fix workflow artifacts #2588

merged 5 commits into from
Jan 31, 2024

Conversation

nightlark
Copy link
Member

@nightlark nightlark commented Jan 12, 2024

Summary

If merged this pull request will change the uploaded artifact name to be unique; this is a new requirement for the upload-artifact v4 action. The separate download-artifact steps are also combined into a single step (by omitting the name).

Proposed changes

  • Make the upload artifact name unique for benchmark package artifacts
  • Make the upload artifact name unique for release package artifacts
  • Combine the download-artifact steps into a single step
  • Switch type of input for which release artifacts to build to a choice instead of free-form input field

@nightlark nightlark added bug Issue concerning incorrect code operation infrastructure/ci github_actions Pull requests that update GitHub Actions code labels Jan 12, 2024
@nightlark nightlark self-assigned this Jan 12, 2024
@nightlark nightlark force-pushed the fix-workflow-artifacts branch 2 times, most recently from 3f85376 to 481955b Compare January 18, 2024 23:33
@nightlark nightlark merged commit 76a5d8e into develop Jan 31, 2024
20 checks passed
@nightlark nightlark deleted the fix-workflow-artifacts branch January 31, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue concerning incorrect code operation github_actions Pull requests that update GitHub Actions code infrastructure/ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants