Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator config #2560

Merged
merged 20 commits into from
Jan 13, 2024
Merged

Translator config #2560

merged 20 commits into from
Jan 13, 2024

Conversation

phlptp
Copy link
Member

@phlptp phlptp commented Aug 30, 2023

Summary

If merged this pull request will add support for translators via config files

Proposed changes

@phlptp phlptp requested a review from nightlark August 30, 2023 12:30
@phlptp phlptp added the enhancement Issue outlines a new capability or improvement in existing capabilities label Aug 30, 2023
@trevorhardy
Copy link
Contributor

Do we think this PR fixes the issues I was having? Also, do you want me to file a bug on it?

@phlptp
Copy link
Member Author

phlptp commented Aug 30, 2023

@trevorhardy file a bug report. I will probably need to add a specific test to verify.

src/helics/core/CommonCore.cpp Outdated Show resolved Hide resolved
src/helics/core/CommonCore.cpp Outdated Show resolved Hide resolved
src/helics/common/addTargets.hpp Outdated Show resolved Hide resolved
src/helics/application_api/Federate.hpp Outdated Show resolved Hide resolved
src/helics/application_api/ValueFederate.cpp Outdated Show resolved Hide resolved
tests/helics/application_api/TranslatorTests.cpp Outdated Show resolved Hide resolved
@phlptp phlptp merged commit 0b530ca into develop Jan 13, 2024
15 of 20 checks passed
@phlptp phlptp deleted the translator_config branch January 13, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue outlines a new capability or improvement in existing capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants