fix code-ql warnings

.github/workflows/codeql.yml

@@ -58,6 +58,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v4
 
+    # tell git that the workspace directory is safe
+    - run: |
+        git config --global --add safe.directory ${GITHUB_WORKSPACE}
+
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3
@@ -80,7 +84,6 @@ jobs:
     - run: |
         echo "Run, Build Application using script"
         unset VCPKG_ROOT
-        git config --global --add safe.directory ${GITHUB_WORKSPACE}
         source scripts/setup-helics-ci-options.sh
         mkdir -p build && cd build
         ../scripts/ci-build.sh

src/helics/application_api/Subscriptions.hpp

@@ -214,8 +214,9 @@ class VectorSubscription2d {
         static_assert(
             std::is_base_of<ValueFederate, std::remove_reference_t<decltype(*valueFed)>>::value,
             "Second argument must be a pointer to a ValueFederate");
-        ids.reserve(count_x * count_y);
-        vals.resize(count_x * count_y, defValue);
+        std::size_t arrayCount=static_cast<std::size_t>(count_x) * static_cast<std::size_t>(count_y);
+        ids.reserve(arrayCount);
+        vals.resizea(arrayCount, defValue);
 
         for (auto ind_x = startIndex_x; ind_x < startIndex_x + count_x; ++ind_x) {
             for (auto ind_y = startIndex_y; ind_y < startIndex_y + count_y; ++ind_y) {

src/helics/application_api/ValueConverter.cpp

@@ -304,7 +304,7 @@ namespace detail {
                 // making use of array oriented access for complex numbers
                 // See https://en.cppreference.com/w/cpp/numeric/complex
                 checks::swapBytes<8>(reinterpret_cast<std::byte*>(&v));
-                checks::swapBytes<8>(reinterpret_cast<std::byte*>(&v) + sizeof(double));
+                checks::swapBytes<8>(reinterpret_cast<std::byte*>(&v) + 8);
             }
         }
     }