Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helicsInputGetComplexVector #33

Merged
merged 6 commits into from
May 10, 2024
Merged

Conversation

josephmckinsey
Copy link
Contributor

I updated the Manifest.toml, since it was testing against HELICS 2.7. We should probably remove the Manifest.toml since most Julia libraries do not have one and instead use better version dependencies like in #30.

Fixes #32.

I also discovered a couple other bugs in that function. One bug involved trying to iterate from 1 to a floating point number, which fails. Another bug involved it casting to a Vector{Float64}.

I may have run a mild formatter on a couple files, which should only change whitespace from what I saw.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 42.71845% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 62.73%. Comparing base (c8f03f1) to head (a890584).

Files Patch % Lines
src/api.jl 42.71% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   61.03%   62.73%   +1.70%     
==========================================
  Files           6        6              
  Lines        1876     1876              
==========================================
+ Hits         1145     1177      +32     
+ Misses        731      699      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephmckinsey josephmckinsey merged commit a28f46f into master May 10, 2024
14 of 16 checks passed
@josephmckinsey josephmckinsey deleted the jm/fix_complex_typo branch May 10, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helicsInputGetComplexVector(), unknown comlexpVector
2 participants