Removed bugs in the SetOption() methods for various interfaces (Filte… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs, Endpoints, Inputs, Publications, etc
phlptp
approved these changes
Aug 24, 2023
nightlark
approved these changes
Aug 30, 2023
nightlark
requested changes
Aug 30, 2023
There was a problem hiding this comment.
At least one CI test failure seems to be from the changes in this PR: https://github.com/GMLC-TDC/HELICS.jl/actions/runs/5814215432/job/16355400577?pr=28#step:5:133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rs, Endpoints, Inputs, Publications, etc
The HELICS.helicsInputSetOption() method has three arguments-
In the Julia API, the data type of the value is restricted to Boolean, whereas in the Python and C API this function accepts an integer value
I observed this issue with other interfaces as well - Publications, Endpoints, and Filters. I made the necessary changes to these functions.