WIP: Support for running tutorials using Docker #6
Conversation
|
As of now, only the 1st tutorial has a Docker Compose configuration. Once I get it fully working I'll work on the other tutorials. |
|
|
||
| WORKDIR /root/develop | ||
|
|
||
| RUN git clone --single-branch -b cmake_update https://github.com/LLNL/GridDyn.git |
There was a problem hiding this comment.
We should use a specific commit for the HELICS-Tutorial. Same for GridLAB-D, HELICS, GridDyn, psst etc.
There was a problem hiding this comment.
@kdheepak I'm assuming you mean update each Dockerfile that's cloning a git repo to use a specific branch, tag, or commit? I think I'm doing that in most, at least a specific branch... perhaps you're suggesting an actual commit hash just in case the branch goes away?
There was a problem hiding this comment.
Yes, I meant to say specific commit hash. In case the branch goes away when merged to another / is updated etc, this will still work. It gives more of a guarantee of reproducibility than just using the branch name.
Using this to track progress against issue #5.