Client-Auth files #21
Conversation
| * client info. | ||
| */ | ||
|
|
||
| const OICCli = require('../init.js').OICCli; |
There was a problem hiding this comment.
Unused constant. Please remove for now.
| */ | ||
|
|
||
| const OICCli = require('../init.js').OICCli; | ||
| const utf8 = require('utf8'); |
There was a problem hiding this comment.
Unused constant. Please remove for now.
|
|
||
| const OICCli = require('../init.js').OICCli; | ||
| const utf8 = require('utf8'); | ||
| const base64url = require('base64url'); |
There was a problem hiding this comment.
Unused constant. Please remove for now.
| } | ||
| } | ||
|
|
||
| function validServiceContext(serviceContext, when) { |
There was a problem hiding this comment.
The name of this function and what it does is not really intuitive. At first I thought it will give a valid ServiceContext object, but when I looked at the code it's checking whether client_secret_expires_at is set and still before the given time.
How about changing the name into something more meaningful? E.g. isValidServiceContext or isServiceContextValid?
It also might make sense to move this function into the ServiceContext class or is there a reason to have it here?
| } | ||
|
|
||
| function validServiceContext(serviceContext, when) { | ||
| let eta = serviceContext['client_secret_expires_at'] || 0; |
There was a problem hiding this comment.
Would it make sense to have client_secret_expires_at defined as a member in ServiceContext, and access it like `serviceContext.client_secret_expires_at? Or is there a reason to access it like it is now?
No description provided.