Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crowdin integration #415

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: crowdin integration #415

wants to merge 10 commits into from

Conversation

ElJocho
Copy link
Collaborator

@ElJocho ElJocho commented Apr 16, 2024

No description provided.

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@TheGreatRefrigerator TheGreatRefrigerator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the linting issues in the yml files. (click red x on the commits or the failing check in the pr)

on:
workflow_dispatch:
schedule:
- cron: '15 * * * *' # sync every hour
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's enough to run this once a day, as the changes aren't released that fast anyway. Or would there be a reason to do this every hour?

Comment on lines +8 to +12

#
# Choose file structure in Crowdin
# e.g. true or false
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#
# Choose file structure in Crowdin
# e.g. true or false
#
# preserve file/folder structure in Crowdin

Comment on lines +14 to +17

#
# Files configuration
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#
# Files configuration
#

Comment on lines +1 to +3
#
# Your Crowdin credentials
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#
# Your Crowdin credentials
#

# Choose file structure in Crowdin
# e.g. true or false
#
"preserve_hierarchy": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would false look like in crowdin?
Would it still have the file names but all next to each other?
I think that would make it a bit easier for translating, if it's mapped back to the repo properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants