feat: Add default config logic #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are used for a variety of tasks mainly around deep copy and deep comparisons of arbitrary objects.
This covers all possible and supported variants of the parameters.
This introduces proper default structures for all different config parts. For settings where a profile makes a difference some switch case are implemented for that logic.
This covers all possible and supported variants of the parameter.
This functionality is anyway shared the same way by all the subclasses.
This fixes some access errors resulting from the merge and adds an initializer to finalize the config once read. Additionally, some tests have been introduced.
This is necessary since most of the code still just uses toString to use the variable. Not a good idea in the first place to work with string variables. But heyho. Let's change that. This behaviour was causing the traffic tests to fail.
This is in case the ors-config.yml doesn't have it.
The folder content changed. Adapting the count entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a streamlined and well-tested config structure with clear default classes and a tested config hierarchy settings management.
We have the following
hierarchy objects:Profile settings: What the user sets underprofile_namein the profiles list.Global profile defaults: What the user sets underprofile_defaults.System profile defaults: Settings that are hardcoded and special for a specific profile. E.g. Wheelchair has a different snapping radius defined.System global profile defaults: Settings that are hardcoded defaults for theprofile_defaultsection.The hierarchy is implemented as followed:
profile settingsalways have the highest precedence and overwrite:User global profile defaults,System profile defaults,System global profile defaults.Global profile defaultshave the next precedence and overwrite:System profile defaults,System global profile defaults.If something is not set by the user at all, the internal logic is as followed:
System profile defaultsare very rare and overwriteSystem global profile defaults.System global profile defaultshave the least precedence and set only what has not been set either by the user or as aSystem profile default.