feat: introduce default config behavior #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used at several places to get the storage access: RAM vs MMAP.
The subclasses got lombok annotations to reduce the boilerplate code.
This function wraps the deepCopyObjectsProperties function and allows to harmonize ExtendedStorageArrays
This adds the extended storages plus their default values per profile including tests.
Each config object has a personal default configuration now, where profile related values are initialized.
Exclude ext_storages from the public transport config and cleanup an old config setter.
This allows for proper deep merging of default config and external ors config properties.
This change streamlines the encoder configuration file names with the other default configurations,
This streamlines the class names with the other default configurations.
… extended storages This gives the feature to avoid overwriting empty member classes or extended storages in case some default values shouldn't be populated with incomplete user settings. One example are the extended storages. If the user decides to set only one extended storage for car we must respect that and not hardcode the remaining default storages. Still we want to have sensible defaults for the existing extended storage if that one is incomplete. Same for execution and processing properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)