allow ContributionView-only filters in contribution extraction endpoints #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
changed the title
tyrasd
force-pushed
the
issue-305
branch
2 times, most recently
from
98492cb
to
aef201c
Compare
joker234
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #305
The problem was that the code used the same method for both the full history data extraction and the "simple" contribution extraction endpoints. While the full history data extraction does in fact not work with contributions-only filters, the code prematurely exited even for the pure contribution extraction use case. This is now fixed by moving the full-history extraction specific code to where it does not interfere with the contribution extraction code path.
Checklist
I have made corresponding changes to the documentationI have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.