fix crash caused by overly complex filters, fixes #330

instead of iterating through the normalized filter, this checks for the presence of non-snapshot compatible filters by recursively searching through the filter tree.

CHANGELOG.md

@@ -1,6 +1,14 @@
 Changelog
 =========
 
+## unreleased
+
+### Bug Fixes
+* Fix crash in non-contribution based endpoints caused by very long and complex filters ([#330])
+
+[#330]: https://github.com/GIScience/ohsome-api/issues/330
+
+
 ## 1.10.3
 
 ### Bug Fixes

src/main/lombok/org/heigit/ohsome/ohsomeapi/inputprocessing/InputProcessingUtils.java

@@ -17,6 +17,7 @@
 import org.heigit.ohsome.ohsomeapi.utils.TimestampFormatter;
 import org.heigit.ohsome.oshdb.OSHDBTag;
 import org.heigit.ohsome.oshdb.api.mapreducer.MapReducer;
+import org.heigit.ohsome.oshdb.filter.BinaryOperator;
 import org.heigit.ohsome.oshdb.filter.ChangesetIdFilterEquals;
 import org.heigit.ohsome.oshdb.filter.ChangesetIdFilterEqualsAnyOf;
 import org.heigit.ohsome.oshdb.filter.ChangesetIdFilterRange;
@@ -407,10 +408,16 @@ public FilterExpression parseFilter(FilterParser fp, String filter) {
    * see also <a href="https://github.com/GIScience/ohsome-api/issues/289">#289</a>.</p>
    */
   public static boolean filterSuitableForSnapshots(FilterExpression filter) {
-    return filter.normalize().stream().flatMap(Collection::stream)
-        .noneMatch(f -> f instanceof ChangesetIdFilterEquals
-                     || f instanceof ChangesetIdFilterRange
-                     || f instanceof ChangesetIdFilterEqualsAnyOf);
+    if (filter instanceof ChangesetIdFilterEquals
+        || filter instanceof ChangesetIdFilterRange
+        || filter instanceof ChangesetIdFilterEqualsAnyOf) {
+      return false;
+    }
+    if (filter instanceof BinaryOperator operator) {
+      return filterSuitableForSnapshots(operator.getLeftOperand())
+          && filterSuitableForSnapshots(operator.getRightOperand());
+    }
+    return true;
   }
 
   /**