Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 7 Support #39

Merged
merged 7 commits into from
Oct 3, 2013
Merged

iOS 7 Support #39

merged 7 commits into from
Oct 3, 2013

Conversation

aparedes
Copy link
Member

  • GIDAAlertView update for iOS 7
  • Layout and tint colors for iOS 7

* GIDAAlertView update for iOS 7
* Layout and tint colors for iOS 7
@ElDeveloper
Copy link
Member

Great work @aparedes!!

This is looking good!

Only funny thing I could found was the about screen with that little gap at the bottom. I have yet to test it on a real device (xcode is being nasty about profiles, etc).

captura de pantalla 2013-09-23 a la s 12 43 38 am

@ElDeveloper
Copy link
Member

Source code looks fine.

The other suggestion I had was to make the back and forward button words to be drawn with a black font.

So in the case of this:

captura de pantalla 2013-09-23 a la s 12 48 25 am

<MATSOL and Solve are drawn in black.

@ElDeveloper
Copy link
Member

This looks so weird:

captura de pantalla 2013-09-23 a la s 1 00 36 am

But I guess it's an iOS 7 feature lol.

@ElDeveloper
Copy link
Member

Also, testing now on device and everything is looking good so far.

@aparedes
Copy link
Member Author

  1. Yeah forgot about the AboutView, I'll do the moving down thing
  2. I don't think I agree with putting the tint in black as everything on the app is white text. I think having it on black will look lazy
  3. Yeah it's very strange the "transparent" UIPickerView, but I think it looks worse on web pages :S but there is nothing to do here unless you want to subclass it, and I think that is not going to happen

@ElDeveloper
Copy link
Member

1.- Thanks.

2.- that's fine.

3.- Yeah Jonathan Ive is a crazy motherfucker. Lol.

Thanks!

Yoshiki Vázquez-Baeza

On Sep 23, 2013, at 2:39 AM, Alejandro Paredes Alva [email protected] wrote:

Yeah forgot about the AboutView, I'll do the moving down thing
I don't think I agree with putting the tint in black as everything on the app is white text. I think having it on black will look lazy
Yeah it's very strange the "transparent" UIPickerView, but I think it looks worse on web pages :S but there is nothing to do here unless you want to subclass it, and I think that is not going to happen

Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

I really don't wanna "be that guy", but it seems our design guidelines are not in compliance with Ive's. Why don't we make a quick attempt on white BG, black fonts and "wire" elements (for example only the black outline of the resistor).

@ElDeveloper
Copy link
Member

Sounds good

Yoshiki Vázquez-Baeza

On Sep 24, 2013, at 6:34 PM, SantiagoTorres [email protected] wrote:

I really don't wanna "be that guy", but it seems our design guidelines are not in compliance with Ive's. Why don't we make a quick attempt on white BG, black fonts and "wire" elements (for example only the black outline of the resistor).


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

I'll give it a go with a sketch for the resistor decoder and see how it goes

@ElDeveloper
Copy link
Member

Thanks.

On Sep 24, 2013, at 7:55 PM, SantiagoTorres [email protected] wrote:

I'll give it a go with a sketch for the resistor decoder and see how it goes


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

Some screenshots of a minimalistic layout
screen shot 2013-09-25 at 2 02 06 am

screen shot 2013-09-25 at 2 02 19 am

The image stopped showing because the XIB broke..., its fixable tho. The code is under my fork/ios7

@ElDeveloper
Copy link
Member

The home screen seems like an easy fix, you've started it just right. Do you think you would be able to get the icons replaced?

Do we want black on white? I was thinking it should stay white but be one of those "Ive" gradients.

I'm not too sure about the color decoder, though @alexwalls thoughts?

Thanks for putting this together

On Sep 25, 2013, at 12:03 AM, SantiagoTorres [email protected] wrote:

Some screenshots of a minimalistic layout

The image stopped showing because the XIB broke..., its fixable tho. The code is under my fork/ios7


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

I'll give it a go tonight also, replacing the icons is an easy fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks

@ElDeveloper
Copy link
Member

Thanks so much this will be a very cool thing to have in place.

As for the xib breaking, I don't know, are you using the latest Xcode? Do you get an error message or something?

Thanks!

Yoshiki.

On Sep 25, 2013, at 9:02 AM, SantiagoTorres [email protected] wrote:

I'll give it a go tonight also, replacing the icons is an easy fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

No,

Elements of the GUI (mostly images and background) start dissapearing
and reappearing. I have to do git clean -df and it fixes it sometimes.

On 09/25/2013 11:27 AM, Yoshiki Vázquez Baeza wrote:

Thanks so much this will be a very cool thing to have in place.

As for the xib breaking, I don't know, are you using the latest Xcode?
Do you get an error message or something?

Thanks!

Yoshiki.

On Sep 25, 2013, at 9:02 AM, SantiagoTorres [email protected]
wrote:

I'll give it a go tonight also, replacing the icons is an easy
fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#39 (comment).

@ElDeveloper
Copy link
Member

Try updating then.

On Sep 25, 2013, at 10:15 AM, SantiagoTorres [email protected] wrote:

No,

Elements of the GUI (mostly images and background) start dissapearing
and reappearing. I have to do git clean -df and it fixes it sometimes.

On 09/25/2013 11:27 AM, Yoshiki Vázquez Baeza wrote:

Thanks so much this will be a very cool thing to have in place.

As for the xib breaking, I don't know, are you using the latest Xcode?
Do you get an error message or something?

Thanks!

Yoshiki.

On Sep 25, 2013, at 9:02 AM, SantiagoTorres [email protected]
wrote:

I'll give it a go tonight also, replacing the icons is an easy
fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#39 (comment).


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

Already latest version, no kidding...

On 09/25/2013 12:35 PM, Yoshiki Vázquez Baeza wrote:

Try updating then.

On Sep 25, 2013, at 10:15 AM, SantiagoTorres
[email protected] wrote:

No,

Elements of the GUI (mostly images and background) start dissapearing
and reappearing. I have to do git clean -df and it fixes it sometimes.

On 09/25/2013 11:27 AM, Yoshiki Vázquez Baeza wrote:

Thanks so much this will be a very cool thing to have in place.

As for the xib breaking, I don't know, are you using the latest
Xcode?
Do you get an error message or something?

Thanks!

Yoshiki.

On Sep 25, 2013, at 9:02 AM, SantiagoTorres
[email protected]
wrote:

I'll give it a go tonight also, replacing the icons is an easy
fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#39 (comment).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#39 (comment).

@aparedes
Copy link
Member Author

  1. I don't know about the white background I think we have a lot of free space and that would look extremely bright but maybe a light gray would look nice and still be on style. (Not all iPhone apps are white)

  2. I really like the simple resistance with no background and not border.  Maybe we could leave a design like that and when you touch it it can show the border of the resistance for a few seconds. (I will make am image later with what I mean)

  3. The crash of the XIB could be related to a deletion of a file (an image). When are you online so we can talk about it?

On Wed, Sep 25, 2013 at 5:13 PM, SantiagoTorres [email protected]
wrote:

I'll give it a go tonight also, replacing the icons is an easy fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks

Reply to this email directly or view it on GitHub:
#39 (comment)

@ElDeveloper
Copy link
Member

Your idea for 2) sounds amazing.

On Sep 25, 2013, at 11:01 AM, Alejandro Paredes Alva [email protected] wrote:

  1. I don't know about the white background I think we have a lot of free space and that would look extremely bright but maybe a light gray would look nice and still be on style. (Not all iPhone apps are white)

  2. I really like the simple resistance with no background and not border. Maybe we could leave a design like that and when you touch it it can show the border of the resistance for a few seconds. (I will make am image later with what I mean)

  3. The crash of the XIB could be related to a deletion of a file (an image). When are you online so we can talk about it?

On Wed, Sep 25, 2013 at 5:13 PM, SantiagoTorres [email protected]
wrote:

I'll give it a go tonight also, replacing the icons is an easy fix... does any of you know why the XIB breaks?

I'll take a look at the Ive gradients and post the looks

Reply to this email directly or view it on GitHub:
#39 (comment)

Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

  1. Yeah, I'll do more sketches for the background. Some gradients like the ones in http://ios7colors.com/ the ones at (2,6) and (4,2) (x,y) look appealing.

  2. This idea might be good, we can also show a "ghost" of some kind (a really really alpha-ed image of the resistor in gray and or black). I'll try to do this today (once I get to fix the XIB).

  3. Not images disappearing, but It happened when I was overwriting the images (the process should be safe tho...) I'm online most of the time at 22:00 EST... might be too late for you. We can also try meeting tomorrow at 11:00 EST?

@ElDeveloper
Copy link
Member

  1. that's a fantastic resource! Look also at http://www.cocoawithlove.com/2008/09/drawing-gloss-gradients-in-coregraphics.html might be relevant.

  2. ok let's see how that works. What are we going to do with iOS 6 and lower?

  3. It's up to you guys, I'm packed for the rest of the week but likely in one week.

On Sep 25, 2013, at 11:14 AM, SantiagoTorres [email protected] wrote:

  1. Yeah, I'll do more sketches for the background. Some gradients like the ones in http://ios7colors.com/ the ones at (2,6) and (4,2) (x,y) look appealing.

  2. This idea might be good, we can also show a "ghost" of some kind (a really really alpha-ed image of the resistor in gray and or black). I'll try to do this today (once I get to fix the XIB).

  3. Not images disappearing, but It happened when I was overwriting the images (the process should be safe tho...) I'm online most of the time at 22:00 EST... might be too late for you. We can also try meeting tomorrow at 11:00 EST?


Reply to this email directly or view it on GitHub.

@aparedes
Copy link
Member Author

Tomorrow 11 est works for me. Also next week. Will try to make some views to compare :)

On Wed, Sep 25, 2013 at 7:14 PM, SantiagoTorres [email protected]
wrote:

  1. Yeah, I'll do more sketches for the background. Some gradients like the ones in http://ios7colors.com/ the ones at (2,6) and (4,2) (x,y) look appealing.
  2. This idea might be good, we can also show a "ghost" of some kind (a really really alpha-ed image of the resistor in gray and or black). I'll try to do this today (once I get to fix the XIB).

3) Not images disappearing, but It happened when I was overwriting the images (the process should be safe tho...) I'm online most of the time at 22:00 EST... might be too late for you. We can also try meeting tomorrow at 11:00 EST?

Reply to this email directly or view it on GitHub:
#39 (comment)

@ElDeveloper
Copy link
Member

It doesn't work for me tomorrow, but I don't need to be on that call, I trust you guys :D

Yoshiki.

On Sep 25, 2013, at 2:00 PM, Alejandro Paredes Alva [email protected] wrote:

Tomorrow 11 est works for me. Also next week. Will try to make some views to compare :)

On Wed, Sep 25, 2013 at 7:14 PM, SantiagoTorres [email protected]
wrote:

  1. Yeah, I'll do more sketches for the background. Some gradients like the ones in http://ios7colors.com/ the ones at (2,6) and (4,2) (x,y) look appealing.
  2. This idea might be good, we can also show a "ghost" of some kind (a really really alpha-ed image of the resistor in gray and or black). I'll try to do this today (once I get to fix the XIB).

3) Not images disappearing, but It happened when I was overwriting the images (the process should be safe tho...) I'm online most of the time at 22:00 EST... might be too late for you. We can also try meeting tomorrow at 11:00 EST?

Reply to this email directly or view it on GitHub:
#39 (comment)

Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

Great, meet you then.
Some previews of the gradients and the (badly drawn) wire resistor
Light gradient:
screen shot 2013-09-25 at 3 37 42 pm

Dark one:
screen shot 2013-09-25 at 4 42 54 pm

Wire resistor:
screen shot 2013-09-25 at 4 42 40 pm

@ElDeveloper
Copy link
Member

That looks amazing, few thoughts:

Changing the font of the text entries from Courier to whatever the font is used all over the OS.
Go for a different background with darker starting points.
Suggest also changing the font for the resistor etc.

If we are changing these few bits we will have to do the same thing with the base converter and with the res calc. Though both of them should be fairly simple once we adopt a theme.

Yoshiki.

On Sep 25, 2013, at 2:45 PM, SantiagoTorres [email protected] wrote:

Great, meet you then.
Some previews of the gradients and the (badly drawn) wire resistor
Light gradient:

Dark one:

Wire resistor:


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

I'll try inverting the gradients and testing it from there.
I think it might be a good idea to release this version and do the GUI redesign as a future update (maybe rush it for the next month?)

Crash for iOS 6.1 and lower where the caputred text was not correctly accessed
Numberpad keyboard and updated range of matrix size
Fixes for XIB and code.
Images are now done programmatically to avoid Xcode corruption
@SantiagoTorres
Copy link
Member

tested, good to go on iOS 6 on device

@ElDeveloper
Copy link
Member

iOS 6? what about iOS 7?

On Sep 26, 2013, at 8:48 PM, SantiagoTorres [email protected] wrote:

tested, good to go on iOS 6


Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

not on my device at least. I think walls did some, he should report results from there.

But hey! it's something!.

@ElDeveloper
Copy link
Member

If @aparedes can confirm then let's wait for that and let's wait for this branch to be merged and for #37 to be merged and I'll submit a new version.

@ElDeveloper
Copy link
Member

It is indeed something.

On Sep 26, 2013, at 10:20 PM, SantiagoTorres [email protected] wrote:

not on my device at least. I think walls did some, he should report results from there.

But hey! it's something!.


Reply to this email directly or view it on GitHub.

@aparedes
Copy link
Member Author

I did check it on ios 7 on a 4in device. 

It works well but there is a bug and I think it's on both ios that when you solve a linear equation and go back there is 2 matrices. It looks really strange if you want to work with your previous matrix but if you are just going home is nothing to worry. Didn't check that much about as I got a bit inspired about GIDACalculateString. 

I can look it over in a couple of hours if no one did

On Fri, Sep 27, 2013 at 6:25 AM, Yoshiki Vázquez Baeza
[email protected] wrote:

It is indeed something.
On Sep 26, 2013, at 10:20 PM, SantiagoTorres [email protected] wrote:

not on my device at least. I think walls did some, he should report results from there.

But hey! it's something!.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub:
#39 (comment)

aparedes and others added 3 commits September 27, 2013 15:47
The matrix was being re-added to the view in `-viewDidAppear:(BOOL)animated`
Use of a flag to avoid addint the matrix again
@SantiagoTorres
Copy link
Member

I didn't get the bug, but on a second check I found the base-selection string said "ocatal" instead of "octal" for both languages.

@aparedes
Copy link
Member Author

The bug happened when you solved the system and go back and pull down the matrix there is another matrix on the background. But now is fixed.

img_1093

Thanks for catching the typo :D

@SantiagoTorres
Copy link
Member

So, I guess it's time to merge #37 If it is not done yet.

@ElDeveloper
Copy link
Member

Hmm that seems like a really annoying bug.

Any idea on what might be going on?

On Sep 27, 2013, at 10:13 AM, Alejandro Paredes Alva [email protected] wrote:

The bug happened when you solved the system and go back and pull down the matrix there is another matrix on the background. But now is fixed.

Thanks for catching the typo :D


Reply to this email directly or view it on GitHub.

@aparedes
Copy link
Member Author

It's fixed

On Sat, Sep 28, 2013 at 12:48 AM, Yoshiki Vázquez Baeza
[email protected] wrote:

Hmm that seems like a really annoying bug.
Any idea on what might be going on?
On Sep 27, 2013, at 10:13 AM, Alejandro Paredes Alva [email protected] wrote:

The bug happened when you solved the system and go back and pull down the matrix there is another matrix on the background. But now is fixed.

Thanks for catching the typo :D


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub:
#39 (comment)

@ElDeveloper
Copy link
Member

Ah sorry, totally missed that!

Kewl!

Yoshiki.

On Sep 27, 2013, at 4:52 PM, Alejandro Paredes Alva [email protected] wrote:

It's fixed

On Sat, Sep 28, 2013 at 12:48 AM, Yoshiki Vázquez Baeza
[email protected] wrote:

Hmm that seems like a really annoying bug.
Any idea on what might be going on?
On Sep 27, 2013, at 10:13 AM, Alejandro Paredes Alva [email protected] wrote:

The bug happened when you solved the system and go back and pull down the matrix there is another matrix on the background. But now is fixed.

Thanks for catching the typo :D


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub:
#39 (comment)

Reply to this email directly or view it on GitHub.

@SantiagoTorres
Copy link
Member

So, guess we should merge and release this weekend 💯

@ElDeveloper
Copy link
Member

If everything is working then merge away and I'll work on the release over the weekend.

On Sep 27, 2013, at 5:51 PM, SantiagoTorres [email protected] wrote:

So, guess we should merge and release this weekend


Reply to this email directly or view it on GitHub.

SantiagoTorres added a commit that referenced this pull request Oct 3, 2013
@SantiagoTorres SantiagoTorres merged commit b7bd3aa into GIDAIbero:master Oct 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants