CopyableLabel in BaseConverter #37
Conversation
UILabel subclass that lets the user copy its content. Closes GIDAIbero#17
| @@ -10,15 +10,19 @@ | |||
| #import "Conversor.h" | |||
| #import "MATSOLDefines.h" | |||
|
|
|||
| @interface CopyableLabel : UILabel | |||
There was a problem hiding this comment.
I think CopybleLabel should be in a separate module and it should be Copyable, there's a letter a missing. Tested this and it's working as expected.
There was a problem hiding this comment.
I understand the part of the separate module and I will consider it but I don't get the other part it says CopyableLabel all over
There was a problem hiding this comment.
Probably misread it, it's 2:53 on this side of the world :P
Yoshiki Vázquez-Baeza
On Sep 23, 2013, at 2:32 AM, Alejandro Paredes Alva [email protected] wrote:
In MATSOL/Classes/BaseConverterViewController.h:
@@ -10,15 +10,19 @@
#import "Conversor.h"
#import "MATSOLDefines.h"+@interface CopyableLabel : UILabel
I understand the part of the separate module and I will consider it but I don't get the other part it says CopyableLabel all over—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Seems to work, decide whether the separate module needs to be rewritten or if I should merge like this.
Bundled resources
|
what do we do with this PR? |
|
Review and then merge? On Oct 12, 2013, at 2:59 PM, SantiagoTorres [email protected] wrote:
|
|
Oh, I was wondering if it was part of the ios7 branch. I'll review it later then. |
…xibs to work on Current and Default Versions
|
@SantiagoTorres, you should have push access to @aparedes fork, you should be able to push your chamges granted that @aparedes aproves! |
|
I didnt' quite get this, am I not pushing to @aparedes 's fork? |
|
Sorry my bad, just checked and you are indeed pushing to @aparedes' fork. Sorry e-mails do not show commit updates. On Oct 16, 2013, at 10:10 AM, SantiagoTorres [email protected] wrote:
|
UILabel subclass that lets the user copy its content. Closes #17