Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bmauer/fixes #2986 #3019

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Feature/bmauer/fixes #2986 #3019

merged 5 commits into from
Sep 10, 2024

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Sep 9, 2024 •
edited
Loading

Fixes #2986
Didn't know whether all connections to fixedVerticalGrid should fail at this point or allow sleazy connections. I can make all fail for now if wanted.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Sep 9, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner September 9, 2024 17:37
tclune
tclune requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor edits and a request to add more unit tests.

tclune
tclune requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor correction to pFUnit usage. Should be able to just accept the changes.

@tclune tclune merged commit 32c3c11 into release/MAPL-v3 Sep 10, 2024
36 checks passed
@tclune tclune deleted the feature/bmauer/fixes-#2986 branch September 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bena-nasa @tclune