Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FixedLevelsVerticalGrid in ComponentSpecParser #2986

Open
tclune opened this issue Aug 22, 2024 · 2 comments
Open

Enable FixedLevelsVerticalGrid in ComponentSpecParser #2986

tclune opened this issue Aug 22, 2024 · 2 comments
Assignees
@tclune @bena-nasa
Labels
📈 MAPL3 MAPL 3 Related

Comments

@tclune
Copy link
Collaborator

tclune commented Aug 22, 2024

We have placeholder logic for BasicVerticalGrid in ComponentSpecParser. Similar logic should be placed for FixedLevelsVerticalGrid. But be mindful of #2985 as it may inform how this is to be done.
@tclune tclune added the 📈 MAPL3 MAPL 3 Related label Aug 22, 2024
@bena-nasa
Copy link
Collaborator

@tclune, where this "placeholder logic"? I'm not seeing anything about this, the word BasicVertical appears nowhere in the ComponentSpecParser than I can see

@tclune
Copy link
Collaborator Author

tclune commented Aug 23, 2024

Oh - sorry about that. Forgot that it is still on my working branch where we did this incidental to the other work. I'll stash my subsequent changes and do a PR shortly.

See #2987

bena-nasa added a commit that referenced this issue Sep 6, 2024
@bena-nasa
fixes #2986
043f044
bena-nasa added a commit that referenced this issue Sep 9, 2024
@bena-nasa
fixes #2986
8cf4dc7
@bena-nasa bena-nasa mentioned this issue Sep 9, 2024
Merged
7 tasks
tclune pushed a commit that referenced this issue Sep 10, 2024
@bena-nasa @tclune
fixes #2986
b5172f4
tclune pushed a commit that referenced this issue Sep 10, 2024
@bena-nasa @tclune
fixes #2986
5ce11ff
tclune added a commit that referenced this issue Sep 10, 2024
@tclune
Merge pull request #3019 from GEOS-ESM/feature/bmauer/fixes-#2986
32c3c11 
Feature/bmauer/fixes #2986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tclune tclune

@bena-nasa bena-nasa

Labels
📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tclune @bena-nasa