Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue between UFS build and standalone CMake #287

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix issue between UFS build and standalone CMake #287

merged 1 commit into from
Aug 26, 2024

Conversation

mathomp4
Copy link
Member

As found by @DusanJovic-NOAA in ufs-community/ufs-weather-model#2399 my previous CMake PR (#273) worked well for us, but broke UFS. Mea culpa.

So, we add CMake to say "if UFS_GOCART is true, so is GOCART_STANDALONE"

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This is a bug fix labels Aug 19, 2024
@mathomp4 mathomp4 self-assigned this Aug 19, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner August 19, 2024 15:50
@mathomp4 mathomp4 mentioned this pull request Aug 19, 2024
Open
vbuchard
vbuchard approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@vbuchard vbuchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt.

@vbuchard vbuchard merged commit bf5cf04 into develop Aug 26, 2024
19 checks passed
@vbuchard vbuchard deleted the bugfix/mathomp4/fix-ufs-standalone branch August 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbuchard vbuchard vbuchard approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This is a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @vbuchard