Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Climatological Anthropogenic Emissions after 2019 #246

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

acollow
Copy link

@acollow acollow commented Jul 24, 2023

This PR modifies the "_ExtData.yaml" files for CA, NI, and SU to persist 2019 anthropogenic emissions as a climatology. Note this version of the PR does NOT include HEMCO diurnal and DoW scaling. During leap years, this will not be zero diff to the previous methodology of copying emissions files with future years in the file name because ExtData2G will update the index of the file one day later. Otherwise, the functionality is the same.

… as a climatology after the end of the CEDS dataset
@acollow acollow added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jul 24, 2023
@acollow acollow requested a review from a team as a code owner July 24, 2023 18:26
… as a climatology after the end of the CEDS dataset
@acollow acollow changed the base branch from main to develop July 24, 2023 19:11
Copy link

@jrjoshi1 jrjoshi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arlindo, Virginie, and I went through the code change and the changes look reasonable. We consider it a 0-diff, although small difference may exist regarding leap years. However, concern still remains that persisting 2019 is not a good idea due to pandemic.

@vbuchard vbuchard merged commit 6f38d02 into develop Mar 7, 2024
8 of 11 checks passed
@vbuchard vbuchard deleted the feature/acollow/extdata2gclimo branch March 7, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants