Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional support for custom_request_handler_class to AMs #927

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wvdemeer
Copy link

@wvdemeer wvdemeer commented Jun 1, 2018

These changes allow an AM implementation to specify a custom request_handler_class to SecureXMLRPCServer. (By adding a static class variable custom_request_handler_class to the class specified as delegate in the config.)

I've used this to add a non XML-RPC site and web service to the AM (both using the same client SSL authentication as the AM).

The small changes in this pull request are quite generic and don't change anything if you don't add custom_request_handler_class to the delegate. So it might be useful to add them.

@dmargery
Copy link
Contributor

dmargery commented Jun 1, 2018

I would certainly use this to host xml schema definitions that are specific to the delegate

@ahelsing
Copy link
Member

ahelsing commented Jun 1, 2018

Looks OK to me from eyeballing it. Users will have to be careful as I'm sure various places in the code assume that the request handler has grabbed the peer certificate, but that's up to the developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants