Copy request cookies from store #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasMerz
reviewed
May 6, 2021
| } | ||
| NSString *header = [array componentsJoinedByString:@";"]; | ||
| NSLog(@"Proxy Setting cookie: %@", header); | ||
| [request setValue:header forHTTPHeaderField:@"Cookie"]; |
There was a problem hiding this comment.
Sorry for the late review.
So this basically sets cookies to the request before sending them? In theory they should already be set by WebKit automatically because they are in the cookie store used by the session that is doing the request.
From my experience this is not really necessary and strangely I did not encouter the issues discussed in #3. Maybe something different is the cause of this issue, but this needs further investigation.
|
FYI I just pulled down the 0.0.4 tag, and it's working for my use case, so I'm going to close this out. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses my issues with #3; I'm able to acquire a cookie in an In App Browser, and pass it through in requests in the Cordova app.
I'm not especially familiar with Objective C, so please let me know if I've done anything non-idiomatic.
Thanks!