[Feature]: CI/CD 추가 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene028
requested review from
ghdtjgus76,
hamo-o and
SeieunYoo
as code owners
hamo-o
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
수고하셨어요!!
++ 서현님이 fetch 내장 클래스 구현하시면서 jest 세팅도 해주셨는데, 테스트 관련 CI CD 설정도 추가하면 좋을 것 같슴당!
SeieunYoo
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
수고 많으셨어요~!
서비스가 어느 정도 완성되면 회의 때 나왔던 lighthouse ci 도 달아보면 좋을 것 같아요
ai 가 pr 리뷰해주는 ci 도 기회되면 활용해봐도 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
현재 백엔드 측에서 서브 도메인 설정을 완료하지 않은 상태라서, 배포된 도메인을 지금 확인해볼 수는 없어요.
remote cache를 이용해서 build 시간 조금이나마 단축하려고 했습니당.
막상 하고 나니까 CI/CD 할 게 별로 없는데.. 추가해야 할 부분이 있다면 언제든지 말씀해주시면 해두겠습니다.