[Refactor] 과제 api 연결 및 바뀐 dto 반영 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeieunYoo
requested review from
ghdtjgus76,
eugene028 and
hamo-o
as code owners
hamo-o
reviewed
Sep 3, 2024
...afterLogin)/my-study/my-assignment/_components/AssignmentContent/RepositorySubmissionBox.tsx
Outdated
Show resolved
Hide resolved
...afterLogin)/my-study/my-assignment/_components/AssignmentContent/RepositorySubmissionBox.tsx
Show resolved
Hide resolved
apps/client/app/(afterLogin)/my-study/my-assignment/_components/AssignmentContent/index.tsx
Outdated
Show resolved
Hide resolved
.../(afterLogin)/my-study/my-assignment/_components/AssignmentHistory/AssignmentHistoryItem.tsx
Outdated
Show resolved
Hide resolved
SeieunYoo
commented
Sep 3, 2024
eugene028
reviewed
Sep 3, 2024
apps/client/app/(afterLogin)/my-study/_components/AssignmentStatusBox.tsx
Outdated
Show resolved
Hide resolved
...afterLogin)/my-study/my-assignment/_components/AssignmentContent/RepositorySubmissionBox.tsx
Show resolved
Hide resolved
...y/my-assignment/_components/AssignmentContent/AssignmentOverviewBox/AssignmentBoxButtons.tsx
Outdated
Show resolved
Hide resolved
ghdtjgus76
reviewed
Sep 3, 2024
.../(afterLogin)/my-study/my-assignment/_components/AssignmentHistory/AssignmentHistoryItem.tsx
Show resolved
Hide resolved
...y/my-assignment/_components/AssignmentContent/AssignmentOverviewBox/AssignmentBoxButtons.tsx
Outdated
Show resolved
Hide resolved
...y/my-assignment/_components/AssignmentContent/AssignmentOverviewBox/AssignmentBoxButtons.tsx
Outdated
Show resolved
Hide resolved
...afterLogin)/my-study/my-assignment/_components/AssignmentContent/RepositorySubmissionBox.tsx
Outdated
Show resolved
Hide resolved
...afterLogin)/my-study/my-assignment/_components/AssignmentContent/RepositorySubmissionBox.tsx
Outdated
Show resolved
Hide resolved
ghdtjgus76
reviewed
Sep 4, 2024
hamo-o
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!
기존에는 레포 입력 모달 창으로 라우팅으로 처리했는데 레포 url 이 입력된 이후에 다시 router.back 을 했을 때 기존의
EDITING상태가 남아있는 이슈가 있었습니다.api 를 쏜 이후에는
SUBMITTED상태가 되는 것이 자연스러워서 상태를 set 해주기 위해 모달을 open 상태를 활용한 컴포넌트로 수정했습니다.(9/3 기준)과제 제출 기능도 잘 처리되는 지 확인 부탁드립니다 !