세미나 출석체크 구현 및 운영서버 에러 메세지 수정 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaejm55
reviewed
Nov 19, 2024
| private final AdminMemberService adminMemberService; | ||
| private final DiscordClient discordClient; | ||
|
|
||
| @GetMapping("members") |
There was a problem hiding this comment.
adminController 니깐 admin/members가 더 좋지 않을까요? 아래 api들도 api/admin/...이 좋아보입니다
There was a problem hiding this comment.
타임리프 바로 띄워서 사용하는거라 로그인 없이 쓸려고 admin prefix 안 붙였습니다
그럼 로그인 페이지까지 만들어야해서 ...
| private final DiscordClient discordClient; | ||
|
|
||
| @GetMapping("members") | ||
| public String getHtml(Model model) { |
There was a problem hiding this comment.
admin 페이지니깐 @TokenMember와 어드민 권한 검증이 필요해보입니다
chaejm55
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 작업 내용
To Reviewers 📢
체크 리스트
➕ 관련 이슈