-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
지원서 조회 / 게시글 댓글 테스트 코드 작성 #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
chaejm55
reviewed
Oct 20, 2024
Comment on lines
74
to
75
.studentNumber("202400"+id) | ||
.phoneNumber("010-0000-"+id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소하긴 한데 그냥 id를 쓰는것 보단 String.format 함수 써서 각각 자릿수 양식에 맞게 만드는 게 조금 더 좋지 않을까 생각해봅니다.
chaejm55
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 작업 내용
지원 현황 조회 테스트 코드 작성
트랙별 지원 개수 테스트 코드 작성
getValidTrack
을 정의하여 UNDEFINED는 제외하고 가져오도록 수정했습니다.임시저장된 지원서를 합/불 처리 하지 못하는지 테스트 코드 작성
댓글 등록 시 그룹이 올바르게 설정되는지 테스트 추가
댓글 페이징 조회시 순서가 올바른지 조회 쿼리 테스트 추가
기존 댓글 관련 테스트 코드 리팩토링
To Reviewers 📢
체크 리스트
➕ 관련 이슈