Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac/issue #112 #114

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Refac/issue #112 #114

merged 10 commits into from
Oct 1, 2024

Conversation

kwonssshyeon
Copy link
Member

@kwonssshyeon kwonssshyeon commented Sep 30, 2024

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • yml ๋ถ„๋ฆฌ ๊ทœ์น™ ๋ณ€๊ฒฝ
  • secret๋ณ€์ˆ˜๋“ค docker ํ™˜๊ฒฝ๋ณ€์ˆ˜๋กœ ์ฃผ์ž…
  • pk ๋„ค์ด๋ฐ ๊ทœ์น™ ํ†ต์ผ
  • user, admin application ๋กœ์ง ์˜ˆ์™ธ์ฒ˜๋ฆฌ ๋ฐฉ์‹ ํ†ต์ผ
  • member, team dto ์œ„์น˜ ๋ณ€๊ฒฝ

To Reviewers ๐Ÿ“ข

  • ๊ธฐ์กด test, dev, main - ๋ธŒ๋žœ์น˜์— ๋”ฐ๋ฅธ profile ๋ช…์—์„œ -> test, dev, prod - ํ™˜๊ฒฝ์— ๋”ฐ๋ฅธ profile ๋ช…์œผ๋กœ ์ˆ˜์ •
  • secret ๊ฐ’๋“ค์€ ์ตœ์ƒ์œ„ ๊ฒฝ๋กœ์˜ .env์—์„œ ๊ด€๋ฆฌ -> ๋…ธ์…˜ ์—…๋ฐ์ดํŠธ ํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค.
  • ์ถ”๊ฐ€๋กœ ๊ฐœ์„ ํ• ๋งŒํ•œ ๋ถ€๋ถ„ 10.01์ž ํšŒ์˜๋ก์œผ๋กœ ์ž‘์„ฑ ํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค.

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

Copy link

github-actions bot commented Sep 30, 2024

Unit Test Results

1 testsโ€‚โ€ƒโ€ƒ1 โœ”๏ธโ€ƒโ€ƒ0s โฑ๏ธ
1 suitesโ€ƒโ€ƒ0 ๐Ÿ’ค
1 filesโ€„โ€‚โ€ƒโ€ƒ0 โŒ

Results for commit 789a397.

โ™ป๏ธ This comment has been updated with latest results.

@kwonssshyeon kwonssshyeon merged commit b5b0abf into dev Oct 1, 2024
3 checks passed
@kwonssshyeon kwonssshyeon deleted the Refac/issue-#112 branch October 1, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants