Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refac/issue #109 #110

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Refac/issue #109 #110

merged 3 commits into from
Sep 25, 2024

Conversation

kwonssshyeon
Copy link
Member

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • ๋ถ€๋ชจํŒ€ ์ฒดํฌ ๊ณตํ†ต ๋กœ์ง์„ ์ถ”์ถœํ•˜์—ฌ ๋ฐ˜๋ณต๋˜๋Š” ์‹ค์ˆ˜๋ฅผ ๋ฐฉ์ง€ํ•œ๋‹ค.
    • member ์—”ํ‹ฐํ‹ฐ์— ๋ฐฐ์ •์ด ์™„๋ฃŒ๋œ team๋งŒ ์กฐํšŒํ•˜๋Š” getter ๋ฉ”์†Œ๋“œ๋ฅผ ์ •์˜ํ•œ๋‹ค
    • ์™ธ๋ถ€์—์„œ๋Š” ์ •์˜ํ•œ getter ๋กœ team์ •๋ณด์— ์ ‘๊ทผํ•œ๋‹ค.

To Reviewers ๐Ÿ“ข

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Unit Test Results

1 testsโ€‚โ€ƒโ€ƒ1 โœ”๏ธโ€ƒโ€ƒ0s โฑ๏ธ
1 suitesโ€ƒโ€ƒ0 ๐Ÿ’ค
1 filesโ€„โ€‚โ€ƒโ€ƒ0 โŒ

Results for commit 78eeb17.

โ™ป๏ธ This comment has been updated with latest results.

@kwonssshyeon kwonssshyeon merged commit bc4c293 into dev Sep 25, 2024
3 checks passed
@kwonssshyeon kwonssshyeon deleted the Refac/issue-#109 branch September 25, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaejm55 chaejm55 chaejm55 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwonssshyeon @chaejm55